#10213 refactor: Raise more consistent errors when a schedule, environment or plugin variant is not found
Pull request opened by
edgarrmondragon
Description
SSIA
Checklist
• I have read the
contribution guide
Was generative AI tooling used to co-author this PR?
• Yes (please specify the tool below)
Related Issues
• Closes #XXXX
Summary by Sourcery
Unify not-found error handling across schedules, environments, and plugin variants by using a shared NotFound/MeltanoError pattern and name-based lookup helpers.
New Features:
• Add NameEq.find_by_name helper for name-based lookup on mixin-based objects.
Bug Fixes:
• Raise consistent NotFound errors when schedules, environments, and plugin variants are missing instead of custom schedule-specific exceptions.
Enhancements:
• Make NotFound a MeltanoError with standardized messages for missing objects.
• Refine equality and hashing semantics for NameEq objects and add typing improvements.
• Improve Environment.find and environment removal behavior to use the shared NotFound error semantics.
• Update plugin variant and extra settings lookup to use typed find_by_name helpers instead of the generic find_named utility.
Documentation:
• Update error documentation to show a StoreNotSupportedError example instead of the removed ScheduleDoesNotExistError.
Tests:
• Adjust schedule, environment, and plugin tests to assert the new NotFound and VariantNotFoundError behaviors and to use type-annotated ScheduleService in tests.
meltano/meltano