Good day. There's a dead link to the GitLab contai...
# documentationh
herman_ewert
04/19/2023, 12:50 PMGood day. There's a dead link to the GitLab container registry on this page (https://docs.meltano.com/guide/containerization). I wanted to just submit a contribution, but I am not sure about the direction there. It would make sense to link to ghcr, but packages has not been enabled on Meltano yet (https://github.com/orgs/meltano/packages), so there is nothing really to link to.
Additionally, it seems that the ghcr publishes were put in place mostly for the scanning, but I am not sure if the use has since expanded to make images generally available via ghcr.
w
Will Da Silva (Arch)
04/19/2023, 12:58 PMHi @herman_ewert. Where/what specifically is the dead link? Meltano publishes to DockerHub, and only uses ghcr for scanning & development purposes.
h
herman_ewert
04/19/2023, 1:01 PMOK, then I will just go ahead and submit a PR to remove the Git*Lab* container registry mention.
herman_ewert
04/19/2023, 1:01 PMThanks for the info
herman_ewert
04/19/2023, 1:05 PM@Will Da Silva (Arch) PR here for more context: https://github.com/meltano/meltano/pull/7571
herman_ewert
04/19/2023, 1:10 PMAlso, for reference the dead link was:
<https://gitlab.com/groups/meltano/-/container_registries/189256?orderBy=NAME&sort=asc&search[]=latest&search[]=>w
Will Da Silva (Arch)
04/19/2023, 1:11 PMThanks for the PR @herman_ewert! I've approved it, and it'll likely be merged later today.
h
herman_ewert
04/19/2023, 1:12 PMOk, awesome. Happy to contribute back!
2 Views