https://linen.dev logo
#plugins-general
Title
# plugins-general
l

laurent

09/09/2021, 9:05 PM
@aaronsteers I hope it's ok to ping you directly. I'm working on the PR for
tap-github
to add the repo list, and I think I caught a bug in the sdk, but wanted to check with you if I'm using it correctly:
Copy code
tap1 = TapGitHub(config=REPO_LIST_CONFIG)
tap1.run_discovery()
catalog = tap1.catalog_dict
set_catalog_stream_selected(catalog, "issue_comments", selected=False)
# now I expect catalog to contain "selected": false for the issue_comments stream, but it doesn't
tap2 = TapGitHub(config=REPO_LIST_CONFIG, catalog=catalog)
tap2.sync_all()
# I would expect tap2 to NOT sync the issue_comments stream
set_catalog_stream_selected
seems to modify a copy of a part of the original catalog, and not the object passed, meaning it seems to have no effect. Is my code above correct (or is the bug in here)?