Hey, so it seems I’ve run into another issue with

tap-adwords

. With @douwe_maan’s fix the config is coming in correctly when I run the tap, but it’s still not selecting any reports besides the default ones (they get logged as

Skipping stream …

). When I look at the streams in the

properties['streams']

object, I see that the new reports I’ve added (like

AGE_RANGE_PERFORMANCE_REPORT

) have

selected

set to

False

. This is true in the

tap.properties.json

file that’s generated in the

run/

folder as well. Any thoughts on how to solve this one? Thanks!

If you run

meltano config tap-adwords list --extras

, you'll see that

tap-adwords

has a default value for the

select

extra (https://meltano.com/docs/plugins.html#select-extra), which contains the entity/stream selection rules set by

meltano select

(https://meltano.com/docs/command-line-interface.html#select). You can also see it in

discovery.yml

: https://gitlab.com/meltano/meltano/blob/master/src/meltano/core/bundle/discovery.yml#L18 By default, unless

select

is overridden, Meltano selects all selectable streams and properties, but this wasn't working well with tap-adwords because (IIRC) some properties are not allowed to be used at the same time, so we added a default set of streams and properties to get it to work out of the box. If you're selecting additional reports using

primary_keys

, you'll also have to select additional streams and their properties using

select

. Default values can't currently be inherited and extended, so you'll have to copy-paste the entire thing from

discovery.yml

to

meltano.yml

and modify it to your liking.

@douwe_maan Thanks so much!! This is exactly what I needed to know 🙌