I am trying to get set up to contribute to Meltano and am ge Meltano #contributing

I am trying to get set up to contribute to Meltano...

Matt Menzenski

12/09/2022, 8:55 PM

I am trying to get set up to contribute to Meltano and am getting a bunch of test failures on a freshly cloned+set up repository. Any obvious things I should be looking into? (logs in thread)

Matt Menzenski

12/09/2022, 8:55 PM

test-logs.txt

Matt Menzenski

12/09/2022, 9:00 PM

I am on a mac, using Python 3.9.11, and followed https://docs.meltano.com/contribute/prerequisites#setting-up-your-environment to set up

Matt Menzenski

12/09/2022, 9:01 PM

it looks like I get the same test failures whether I am running the tests with

poetry shell

followed by

pytest

or just

poetry run pytest

Will Da Silva (Arch)

12/09/2022, 10:31 PM

Do you have Docker and

docker-compose

installed?

Will Da Silva (Arch)

12/09/2022, 10:32 PM

It seems like the contributing docs have fallen out of date. Sorry about that. I'll see if I can fix that once we've got your setup fixed.

Matt Menzenski

12/09/2022, 10:32 PM

yes to both, docker 20.10.0 and docker-compose 1.27.4

Will Da Silva (Arch)

12/09/2022, 10:36 PM

What happens if you run the following?

Copy code

cd tests/fixtures/docker
docker-compose up --force-recreate snowplow

Matt Menzenski

12/09/2022, 10:37 PM

Copy code

$ docker-compose up --force-recreate
Creating network "docker_default" with the default driver
Creating docker_snowplow_1 ... done
Attaching to docker_snowplow_1
snowplow_1  |
snowplow_1  | No java installations was detected.
snowplow_1  | Please go to <http://www.java.com/getjava/> and download
snowplow_1  |
docker_snowplow_1 exited with code 1

Matt Menzenski

12/09/2022, 10:37 PM

I do have several java JDKs installed, should I be using one in particular?

Matt Menzenski

12/09/2022, 10:37 PM

it’s using JDK14 right now

Will Da Silva (Arch)

12/09/2022, 10:39 PM

I'm not sure what version of Java is needed. It's whatever is needed by https://github.com/snowplow-incubator/snowplow-micro

Will Da Silva (Arch)

12/09/2022, 10:39 PM

When you run

which java

, you get a path to a Java executable, right?

Matt Menzenski

12/09/2022, 10:39 PM

yes,

/usr/bin/java

Will Da Silva (Arch)

12/09/2022, 10:41 PM

You probably don't need to worry about the tests that depend on this Docker container, so I'm going to suggest we forgo figuring out why it isn't working for you, and just focus on getting you up and running. If you edit

tests/fixtures/docker/snowplow.py

such that the first line of the

snowplow_session

function is

return None

, that should fix the problem.

Will Da Silva (Arch)

12/09/2022, 10:42 PM

I'll update it properly so that issues like this don't affect others in the future. It's supposed to be optional, but it only checks if you have

docker-compose

, not if the container can actually start.

Will Da Silva (Arch)

12/09/2022, 10:50 PM

https://github.com/meltano/meltano/pull/7067

Matt Menzenski

12/09/2022, 10:54 PM

thanks!

Will Da Silva (Arch)

12/09/2022, 10:54 PM

No problem. Please let me know if that fixed everything, or if there's more I can do to help.

Matt Menzenski

12/09/2022, 10:54 PM

I’ve confirmed that if I replace that

snowplow_session

function body with

yield None

, all tests run sucessfully

Matt Menzenski

12/12/2022, 2:49 PM

sorry - apparently I spoke too soon on that facepalm still getting a couple errors for missing module

azure

Copy code

ERROR tests/meltano/core/state_store/test_filesystem.py - ModuleNotFoundError: No module named 'azure'
ERROR tests/meltano/core/state_store/test_filesystem.py - ModuleNotFoundError: No module named 'azure'
ERROR tests/meltano/core/state_store/test_filesystem.py - ModuleNotFoundError: No module named 'azure'
ERROR tests/meltano/core/state_store/test_filesystem.py - ModuleNotFoundError: No module named 'azure'
ERROR tests/meltano/core/state_store/test_filesystem.py
ERROR tests/meltano/core/state_store/test_filesystem.py - ModuleNotFoundError: No module named 'azure'
ERROR tests/meltano/core/state_store/test_filesystem.py - ModuleNotFoundError: No module named 'azure'
ERROR tests/meltano/core/state_store/test_filesystem.py - ModuleNotFoundError: No module named 'azure'
ERROR tests/meltano/core/state_store/test_filesystem.py - ModuleNotFoundError: No module named 'azure'
FAILED tests/meltano/core/tracking/test_exception.py::test_complex_exception_context - AssertionError: assert '07d2ff4730eb...7f13790e2a65d' == '8604732e6dd0...79a0b758155d0'

Will Da Silva (Arch)

12/12/2022, 2:49 PM

You'll want to run

poetry install --all-extras

Matt Menzenski

12/12/2022, 2:50 PM

ah, thank you!

Matt Menzenski

12/12/2022, 2:58 PM

Getting just one failure now:

Copy code

FAILED tests/meltano/core/tracking/test_exception.py::test_complex_exception_context - AssertionError: assert '07d2ff4730eb...7f13790e2a65d' == '8604732e6dd0...79a0b758155d0'

Will Da Silva (Arch)

12/12/2022, 3:08 PM

That will be somewhat more difficult to correct without me being able to interact with the environment in which it is occurring. I'll try to reproduce it. What version of macOS are you using? You're using CPython (the standard Python implementation) version 3.9.11, right? And Meltano + its dependencies installed from

main

Matt Menzenski

12/12/2022, 3:24 PM

macOS 12.6 Monterey my fork of meltano is one commit behind main https://github.com/menzenski/meltano Python 3.9.11 installed from

pyenv install 3.9.11

Will Da Silva (Arch)

12/12/2022, 7:15 PM

I have reproduced the error. Looking into it now.

Will Da Silva (Arch)

12/12/2022, 10:03 PM

Sorry for the delay. I have opened a PR with the fix: https://github.com/meltano/meltano/pull/7076

3 Views

Open in Slack

Previous Next