Hello! Potential first time contributor here. I'm ...
# contributingw
warren_ersly
02/08/2022, 4:41 PMHello! Potential first time contributor here. I'm interested in making a pull request to tap-gitlab (I've extended the tap to recognize/handle project level variables and group level variables , some attributes which I'm interested in extracting). Is there any particular workflow, or otherwise special forms that I should observe in doing so?
a
aaronsteers
02/08/2022, 6:16 PMHi, @warren_ersly! Welcome! That tap is admittedly overdue to be migrated to the SDK, which would add much-needed test capabilities and would reduce the overall lines of code, I think.
aaronsteers
02/08/2022, 6:18 PMBut to your question, while we don't yet have CI flow set up, the things that are super helpful there as you submit a PR to the repo are:
• try to just touch the lines of code that are adding functionality.
• include in your PR a list of tests you've run locally.
• include in your PR any risks, tradeoffs, or backwards compatibility issues if applicable.
aaronsteers
02/08/2022, 6:19 PMOn the other hand, if you do have capacity and interest to help us port this to the SDK, there's actually already a sample in the SDK's repo of how Gitlab auth can work with the SDK, along with a few sample streams already defined in a parent-child structure. In theory, you could iterate from that - but admittedly it's a lot of work to do so.
w
warren_ersly
02/08/2022, 6:40 PMsubmit a PR to the repoGreat pointers, thanks @aaronsteers! I'll get this stuff together as soon as I can and submit.
port this to the SDKI have little capacity for this at the moment, but this does seem like a potentially useful task for familiarizing myself with the SDK. I may look into it when I have the time!
a
aaronsteers
02/08/2022, 7:24 PMGreat, thankyou, @warren_ersly!
w
warren_ersly
02/10/2022, 4:40 AMPR is up for loading GitLab project and group variables in tap-gitlab! Let me know if there's anything I can change or improve here.
5 Views