josue_sehnem
04/21/2023, 8:27 PMgary_james
04/21/2023, 8:52 PMdan_ladd
04/21/2023, 11:50 PMjosue_sehnem
04/23/2023, 3:17 PMken_payne
04/24/2023, 3:40 PMSOAPStream class and Connection for the SDK? It would be epic to collect your feedback and learnings on SOAP with the SDK, as a starting point to adding native SOAP support 🙂 👍 Looks like there is an old issue for 🧼 already, but feel free to create a fresh one to point at the work you’ve done on tap-netsuite 🙌 🚀josue_sehnem
04/24/2023, 3:51 PMken_payne
04/24/2023, 5:48 PMjosue_sehnem
04/24/2023, 6:13 PMConnection and SOAPStream (or SoapStream) classes for the netsuite tap, based on the sql cookiecutter and sdk code. I think the conversion to JSONSchema should be the same, since I’m using the zeep types. However, I’m wondering if adding zeep as a dependency would cause any issues for the SDK. I saw in the issue discussion that you shared that some people suggested using only the request library, but I’m not sure if that’s a good idea, as it might make things too complex.
The list of endpoint that will be fetched may not be totally dynamic, in cases as netsuite just some of the elements are fetchable and rely on other complex type that are used to fetch it. Will try to look at other API and see how it works in there (I don’t think it should be more complex than netsuite)
Once I have basic POC I will let create new issue describing my approach.ken_payne
04/24/2023, 6:45 PMtap-netsuite is a great place to start a generic implementation, thank you 👍 As to dependencies, we can add zeep to the SDK as an optional dependency, so future soap taps can depend on singer-sdk[soap] if they want to leverage the soap base classes 🙂 We are planning to do the same for sqlalchemy in the next major version of the SDK for the same reason 🚀