<#3670 feat: allow disabling SQL view discovery> P...
# meltano-repo-activity
g
#3670 feat: allow disabling SQL view discovery Pull request opened by Dexter2099 Fixes #2806. Summary • Add built-in SQL tap settings for
discover_views
and
discover_materialized_views
. • Pass those settings from
SQLTap
into catalog discovery. • Let
SQLConnector.discover_catalog_entries()
reflect tables, views, and materialized views according to those flags while preserving the existing default behavior. • Add connector and tap-level regression coverage. Validation •
uv run pytest tests/sql/test_connector.py::TestDummySQLConnector::test_discover_catalog_entries_can_exclude_views tests/sql/test_connector.py::TestDummySQLConnector::test_discover_catalog_entries_can_filter_materialized_views tests/sql/test_connector.py::test_sql_tap_passes_discovery_settings_from_config -q
•
uv run pytest tests/sql/test_connector.py -q
•
uv run pytest tests/sql -q
•
pre-commit run --files singer_sdk/helpers/capabilities.py singer_sdk/sql/connector.py singer_sdk/sql/tap.py tests/sql/test_connector.py
•
NOX_DEFAULT_VENV_BACKEND=uv nox -rs tests-3.11 -- tests/sql
•
uv run pytest tests/packages/test_tap_sqlite.py -m packages -q
Summary by Sourcery Allow SQL taps and connectors to control whether views and materialized views are included during catalog discovery while preserving existing default behavior. New Features: • Add SQL tap configuration options to toggle discovery of views and materialized views. • Expose discovery flags on SQLConnector.discover_catalog_entries to control reflection of tables, views, and materialized views. Tests: • Add regression tests for SQLConnector discovery filtering of views and materialized views and for passing tap-level discovery settings into the connector. meltano/sdk