<#3671 feat: support filtering SQL tap schemas> Pu...
# meltano-repo-activity
g
#3671 feat: support filtering SQL tap schemas Pull request opened by Dexter2099 Summary • add a
filter_schemas
SQL tap config option for limiting schema discovery • pass configured schema filters into SQL connector discovery • preserve compatibility with custom connectors that override
discover_catalog_entries
without the new keyword Closes #1930. Testing •
uv run pytest tests/sql/test_connector.py -k "filter_schemas" -q
•
uv run pytest tests/sql/test_connector.py -q
•
uv run pytest tests/sql -q
•
uv run pytest tests/packages/test_tap_sqlite.py -m packages -q
•
pre-commit run --files singer_sdk/helpers/capabilities.py singer_sdk/sql/connector.py singer_sdk/sql/tap.py tests/sql/test_connector.py
Summary by Sourcery Add configurable schema filtering to SQL taps while preserving compatibility with existing connectors' discovery signatures. New Features: • Introduce a SQL tap configuration option to filter discovered schemas via the filter_schemas setting. Enhancements: • Pass configured schema filters from SQLTap into SQLConnector discovery and apply them when enumerating schemas. • Extend SQL tap configuration schema to document and validate the new filter_schemas option. • Ensure SQL tap discovery gracefully handles custom connectors that use a legacy discover_catalog_entries signature without filter_schemas. Tests: • Add SQL connector and SQL tap tests covering schema filtering behavior and compatibility with legacy connector discovery implementations. meltano/sdk